This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: hardcode autopush_rs's AWS creds in local dynamodb mode #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and kill now unneeded automock / boto.cfg files and the old Dockerfile.automock that nobody uses any more Closes #1201
pjenvey
added this to the 2018Q2-2.1 Rust connection node with broadcast deployed to Prod milestone
jrconlin
approved these changes
May 4, 2018
Codecov Report
@@ Coverage Diff @@
## master #1214 +/- ##
======================================
Coverage 100% 100%
======================================
Files 60 60
Lines 10194 10194
======================================
Hits 10194 10194Continue to review full report at Codecov.
|
bbangert
approved these changes
May 5, 2018
The if else block causes the DynamoDbClient struct to be different enough (its associated types) that we have to refer to it via its trait now (DynamoDb). So without impl trait we have to box it to return it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and kill now unneeded automock / boto.cfg files and the old
Dockerfile.automock that nobody uses any more
Closes #1201