This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: port drop user command to Rust #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbangert
force-pushed
the
feat/issue-1207
branch
3 times, most recently
from
d7ba3c5 to
c1965be
Compare
pjenvey
reviewed
May 10, 2018
autopush_rs/src/client.rs
Outdated
| @@ -592,7 +592,7 @@ where | |||
|
|
|||
| #[state_machine_future(transitions(AuthDone))] | |||
| AwaitDropUser { | |||
| response: MyFuture<call::DropUserResponse>, | |||
| response: MyFuture<bool>, | |||
There was a problem hiding this comment.
we don't look at the result anyway, so use nil () instead
bbangert
force-pushed
the
feat/issue-1207
branch
2 times, most recently
from
871ff4b to
ca0a189
Compare
pjenvey
previously approved these changes
May 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #1223 +/- ##
=========================================
+ Coverage 99.99% 100% +<.01%
=========================================
Files 60 60
Lines 10198 10198
=========================================
+ Hits 10197 10198 +1
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
pjenvey
approved these changes
May 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1207