This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: improve endpoint_diagnostic tool and documents #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
reviewed
Aug 7, 2018
autopush/diagnostic_cli.py
Outdated
| ) | ||
| uaid, chid = parsed["uaid"], parsed["chid"] | ||
| except (InvalidTokenException, InvalidToken) as ex: | ||
| print("Token could not be deciphered. Are you using the correct" |
There was a problem hiding this comment.
is it worth including the exception in this message (I'm leaning towards sure, why not)?
There was a problem hiding this comment.
Yeah, was kinda on the fence. Mostly because the bulk was "Invalid Token", but yeah, there are times it's useful to dump as well.
pjenvey
previously approved these changes
Aug 7, 2018
Codecov Report
@@ Coverage Diff @@
## master #1282 +/- ##
======================================
Coverage 100% 100%
======================================
Files 59 59
Lines 9531 9559 +28
======================================
+ Hits 9531 9559 +28
Continue to review full report at Codecov.
|
pjenvey
approved these changes
Aug 7, 2018
bbangert
approved these changes
Aug 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1281