This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: Limit the size of allowed HTTP bodies & headers #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #602 diff @@
======================================
Files 42 44 +2
Lines 8872 8944 +72
Methods 0 0
Messages 0 0
Branches 0 0
======================================
+ Hits 8869 8944 +75
+ Misses 3 0 -3
Partials 0 0
|
Limits the amount of data preventing a potential DDoS. This extends much of what's already in place. Twisted limits TCP read chunks to 65K. It also already limits the max length of header lines to 16,384 bytes. This forces connections closed if too much data is attempted to be sent. NOTE: currently too much data events are not being logged, mostly due to the fact that errors would lack a good deal useful info. Closes #501
| rest = '' | ||
|
|
||
| self._contentbuffer.write(data) | ||
| if self.content_length <= 0: |
There was a problem hiding this comment.
nice bugfix (I noticed this is == 0 in cyclone) =]
|
r+ I'll note (per your comment on #501) you can also override a factory's buildProtocol to pass the protocol values at runtime (like maxData). That requires customizing your own factory, usually subclassing, though, so it's extra work (I'm totally fine with this patch though, we already do this unclean assignment w/ PushServerProtocol in main.py) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the amount of data preventing a potential DDoS. This extends much
of what's already in place. Twisted limits TCP read chunks to 65K. It
also already limits the max length of header lines to 16,384 bytes. This
forces connections closed if too much data is attempted to be sent.
NOTE: currently too much data events are not being logged, mostly due
to the fact that errors would lack a good deal useful info.
@pjenvey r?