This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: capture and metric item not found instead of log #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
approved these changes
Mar 1, 2017
autopush/tests/test_websocket.py
Outdated
| reactor.callLater(0.1, wait_for_agent_call) | ||
| return d | ||
|
|
||
| def test_close_with_delivery_cleanup_and_no_get_uaid_error(self): |
pjenvey
reviewed
Mar 1, 2017
autopush/tests/test_websocket.py
Outdated
| @@ -7,7 +7,8 @@ | |||
|
|
|||
| import twisted.internet.base | |||
| from autopush.tests.test_db import make_webpush_notification | |||
| from boto.dynamodb2.exceptions import ProvisionedThroughputExceededException | |||
| from boto.dynamodb2.exceptions import ProvisionedThroughputExceededException, \ | |||
pjenvey
approved these changes
Mar 1, 2017
There's no need to log exceptions failing to save a message for a user that has been deleted. Now a metric will be emitted instead. This also tweaks the tox runner to no longer include object memory tracking by default. Closes #811
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
=======================================
Coverage 100% 100%
=======================================
Files 48 48
Lines 9446 10146 +700
=======================================
+ Hits 9446 10146 +700
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to log exceptions failing to save a message for a
user that has been deleted. Now a metric will be emitted instead.
This also tweaks the tox runner to no longer include object memory
tracking by default.
Closes #811