bug-1909637: allow searching for files from regular and try symbol uploads #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loads
Previously, you could sort of search for try uploads by searching for
"try/" in the key. But you couldn't search for regular uploads.
We recently changed the key data in the model, so "try/" no longer
appears in the key which breaks this flimsy filtering method.
This introduces a new upload_type filter field that lets you filter on
nothing (""), try upload files ("try"), and regular upload files
("regular").
willkg
force-pushed
the
willkg-bug-1909637-search-try
branch
from
f8b4b52 to
7138777
Compare
relud
approved these changes
Aug 19, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you could sort of search for try uploads by searching for "try/" in the key. But you couldn't search for regular uploads.
We recently changed the key data in the model, so "try/" no longer appears in the key which breaks this flimsy filtering method.
This introduces a new upload_type filter field that lets you filter on nothing (""), try upload files ("try"), and regular upload files ("regular").