Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update golang version in Dockerfile #202

Merged
merged 2 commits into from
May 17, 2023
Merged

update golang version in Dockerfile #202

merged 2 commits into from
May 17, 2023

Conversation

mozkeeler
Copy link
Collaborator

This works for me locally, but I don't know that I've addressed all of the issues currently preventing it from working in production.

@mozkeeler mozkeeler requested a review from jschanck April 21, 2023 21:30
@mozkeeler mozkeeler self-assigned this Apr 21, 2023
@mozkeeler
Copy link
Collaborator Author

(Context is https://bugzilla.mozilla.org/show_bug.cgi?id=1816759#c3)

jschanck
jschanck approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@jschanck jschanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Sorry I didn't see this sooner. Looks like I need to review my notification settings for github.

@mozkeeler mozkeeler requested a review from smarnach April 26, 2023 16:20
@smarnach smarnach merged commit dddef20 into main May 17, 2023
@smarnach smarnach deleted the fix-build branch May 17, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarnach smarnach smarnach approved these changes

@jschanck jschanck jschanck approved these changes

Assignees

@mozkeeler mozkeeler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mozkeeler @smarnach @jschanck