[Bug 1753838] Harden trailing slashes redirect #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escapewindow
suggested changes
Feb 7, 2022
| if request.path.endswith('/'): | ||
| return web.HTTPFound('/' + request.path.strip('/')) | ||
| return web.HTTPFound('/' + request.path.strip('/'+string.whitespace)) |
There was a problem hiding this comment.
Have you verified that this will fix the issue?
This seems like a good candidate for a unit test.
There was a problem hiding this comment.
I have added unit tests now - thanks.
Running locally, I reproduced the issue reported in bug 1753838 with requests like http://localhost:9876/%0a/www.google.com/. Without changes, that redirects to www.google.com; with this patch, pollbot reports:
{"status": 404, "message": "Page '/www.google.com' not found"}
escapewindow
approved these changes
Feb 7, 2022
gbrownmozilla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.