Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure ESLint doesn't fail with invalid JS (syntax_error rule) #52

Closed
tofumatt opened this issue Oct 6, 2015 · 0 comments
Closed
Assignees

Comments

@tofumatt
Copy link
Contributor

tofumatt commented Oct 6, 2015

This is a test case I hadn't considered in #44; I'll leave it here as a separate bug.

We should be sure bad JS like:

var = foo:

doesn't crash the validator.

Turns out this is the syntax_error rule. This is a good one to implement early I think.

@tofumatt tofumatt added the 44.2 label Oct 6, 2015
@tofumatt tofumatt self-assigned this Oct 6, 2015
tofumatt added a commit that referenced this issue Oct 7, 2015
Adds a test case for malformed JS and a bit of extra code in the
JS Scanner to make sure we handle SyntaxErrors, which are a bit
different from other errors created by ESLint.

Fixes #52.
tofumatt added a commit that referenced this issue Oct 8, 2015
Adds a test case for malformed JS and a bit of extra code in the
JS Scanner to make sure we handle SyntaxErrors, which are a bit
different from other errors created by ESLint.

Fixes #52.
tofumatt added a commit that referenced this issue Oct 8, 2015
Adds a test case for malformed JS and a bit of extra code in the
JS Scanner to make sure we handle SyntaxErrors, which are a bit
different from other errors created by ESLint.

Fixes #52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant