Async/await refactoring for tests/io folder - test.xpi.js #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the hiccup and weird test breakage, #1749 just got merged and once you rebase your branch to master tests should be working fine again :) |
rpl
requested changes
Jan 12, 2018
tests/io/test.xpi.js
Outdated
| expect(err.message).toContain('open() test'); | ||
| }); | ||
|
|
||
| try { |
tests/io/test.xpi.js
Outdated
| }); | ||
| const readStream = await myXpi.getFileAsStream('manifest.json'); | ||
|
|
||
| const onceReadString = new Promise((resolve, reject) => { |
rpl
approved these changes
Jan 22, 2018
There was a problem hiding this comment.
Thanks a lot @hameleonka!
This test file is now much more readable!
@EnTeQuAk This PR should now be ready for you!
|
Glorious, merged! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rpl in this PR I've worked on test.xpi.js in tests/io folder. Please check it out, waiting for your review.