Fixup dependency mess #1749
Merged
Fixup dependency mess #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inter into fixup-dependency-mess
rpl
requested changes
Jan 11, 2018
| @@ -62,6 +62,7 @@ | |||
| "is-mergeable-object": "1.1.0", | |||
| "isparta": "4.0.0", | |||
| "jest": "22.0.4", | |||
| "jest-cli": "22.0.4", | |||
There was a problem hiding this comment.
👍 it looks that is this explicit dependency on jest-cli that is fixing the issue
I think that we can remove the "jest" dependency above it, so that we don't need to keep them in sync when we upgrade jest (I tried locally and it worked fine).
There was a problem hiding this comment.
Hmm, that's actually true but given that jest only has jest-cli as a dependency we don't have to pin anything right now. Once they pin jest-cli we can get rid of the explicit dependency.
rpl
approved these changes
Jan 11, 2018
This was referenced Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs webpack/webpack-dev-server#1259 (comment)
Refs jestjs/jest#3793