Restore newlines in CLI output

[tofumatt]

Just realised that when we added the singleLineString template tag in #41, we removed intentional newlines before JSON strings (eg: https://github.com/mozilla/addons-validator/blob/master/src/cli.js#L63).

This restores them in a way I hope isn't offensive. I still think it's nicer (and more explicit/obvious) than just allowing string concat on that line.

r?

[muffinresearch]

Does the newline being removed matter that much? yargs own formatting seems to break up strings anyway. How different is the actual output before and after?

[tofumatt]

It lets you see the JSON string on one line… but I guess the formatting is a bit weird anyway.

vs:

I added this and meant to ask if it was worth it... and if it was I'd add a test. Now I'm thinking it's silly. Feel free to close if you agree 😉

[muffinresearch]

Yeah we should probably rip the examples out. The cli help doesn't seem like a great place for that. I'll close this for now but if we want it back we can always revisit.

[tofumatt]

Sounds good. Thanks. 👍

• tofumatt

On 2 October 2015 at 14:58:31, Stuart Colville (notifications@github.com) wrote:

Yeah we should probably rip the examples out. The cli help doesn't seem like a great place for that. I'll close this for now but if we want it back we can always revisit.

—
Reply to this email directly or view it on GitHub.