Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle duplicate files in xpi (fixes #38, fixes #37) #43

Merged
merged 2 commits into from
Oct 5, 2015
Merged

Handle duplicate files in xpi (fixes #38, fixes #37) #43

merged 2 commits into from
Oct 5, 2015

Conversation

muffinresearch
Copy link
Contributor

Ended up covering a quite a lot of ground here - as yaks reared their ugly heads I shaved them :).

  • collector messageType lists are now produced through iterating over constants
  • messageTypes are now constants
  • required message types are handled (see Test to make sure Message has required opts #38)
  • Xpi throws a custom exception DuplicateZipEntryError when an entry already seen comes up.
  • Validator now has a output property and a toJSON method + a print() method.
  • Fixed a race condition in the Xpi class. We now listen to close rather than end because the latter resulted in resolution of the promise before the last entry was processed (and rejected).

tofumatt
tofumatt reviewed Oct 2, 2015
View reviewed changes
src/collector.js
this.errors = [];
this.notices = [];
this.warnings = [];
for (let type of constants.MESSAGE_TYPES) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@tofumatt
Copy link
Contributor

tofumatt commented Oct 2, 2015

r+

This is splendid!

tofumatt added a commit that referenced this pull request Oct 4, 2015
@tofumatt
Check for mozIndexedDB; close #15
4496127 
This adds support for custom ESLint rules. It will probably conflict
with #43. It's been modified to make use of the messages structure in there.

We can merge #43 in first, then do this.
@tofumatt tofumatt mentioned this pull request Oct 4, 2015
Merged
muffinresearch added a commit that referenced this pull request Oct 5, 2015
@muffinresearch
Merge pull request #43 from muffinresearch/dupe-zip-entry
9747571 
Handle duplicate files in xpi (fixes #38, fixes #37)
@muffinresearch muffinresearch merged commit 9747571 into mozilla:master Oct 5, 2015
@muffinresearch muffinresearch deleted the dupe-zip-entry branch October 5, 2015 08:32
tofumatt added a commit that referenced this pull request Oct 5, 2015
@tofumatt
Check for mozIndexedDB; close #15
dbfd899 
This adds support for custom ESLint rules. It will probably conflict
with #43. It's been modified to make use of the messages structure in there.

We can merge #43 in first, then do this.
tofumatt added a commit that referenced this pull request Oct 6, 2015
@tofumatt
Check for mozIndexedDB; close #15
9e27f0e 
This adds support for custom ESLint rules. It will probably conflict
with #43. It's been modified to make use of the messages structure in there.

We can merge #43 in first, then do this.
tofumatt added a commit that referenced this pull request Oct 6, 2015
@tofumatt
Check for mozIndexedDB; close #15
a43995b 
This adds support for custom ESLint rules. It will probably conflict
with #43. It's been modified to make use of the messages structure in there.

We can merge #43 in first, then do this.
@willdurand willdurand mentioned this pull request Oct 11, 2019
Merged
@data-sync-user data-sync-user mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muffinresearch @tofumatt