Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

Adds public cross-system BadgeClass listing #120

Merged
merged 2 commits into from
Jul 31, 2014

Conversation

cmcavoy
Copy link
Contributor

@cmcavoy cmcavoy commented Jul 15, 2014

For #119.

Example of the output is here: https://gist.github.com/cmcavoy/7ad769d76c91c8832bdd

@kayelle @jpcameron can you take a look at the gist and let me know if that output is ok?

example, but it's possible that it will work. Need confirmation.
@ottonomy
Copy link

I would really want to see the URL location of the badgeclass as publicly accessible through BadgeKit as part of that output.

@threeqube
Copy link

@cmcavoy I think you meant @jpcamara and @kayaelle

@kayaelle
Copy link

BIG apologies. I gave you the wrong example for the badge class listing. It is way simpler - just a list of badge class locations.

Here's a json example: https://gist.github.com/kayaelle/0ad933c2528fde4b829b

@cmcavoy
Copy link
Contributor Author

cmcavoy commented Jul 17, 2014

Just to be clear - the list should be of url's pointing at BadgeClasses.

@kayaelle
Copy link

Exactly - you can read more here: http://mozilla.github.io/openbadges-directory/#addbadges

@cmcavoy cmcavoy self-assigned this Jul 17, 2014
@cmcavoy
Copy link
Contributor Author

cmcavoy commented Jul 18, 2014

Ok, it's updated to match the specification listed on the directory page. Example output https://gist.githubusercontent.com/cmcavoy/cb9de5db668e7f7c3713/raw/4477e0b341eab00bd68162cd1ed34c2abfe12d40/gistfile1.json

What say ye @brianloveswords @christensenep @kayaelle @ottonomy @jpcamara?

@ottonomy
Copy link

👍 👍

My only tiny consideration would be that this format is really close to being able to deliver full Badge Class objects, as they appear baked by the current Backpack Issuer API, except that the Backpack uses the "_location" property instead of "location". On the other hand, it seems kind of silly to use "_location" when the only purpose of the list is sharing URLs though.

@cmcavoy
Copy link
Contributor Author

cmcavoy commented Jul 31, 2014

Noted @ottonomy . Going to move the format discussion to the directory repo. For now I'm going to merge and push this to prod.

cmcavoy added a commit that referenced this pull request Jul 31, 2014
Adds public cross-system BadgeClass listing
@cmcavoy cmcavoy merged commit 718257f into master Jul 31, 2014
@cmcavoy cmcavoy deleted the 119-add-public-badge-list branch July 31, 2014 15:42
@ottonomy
Copy link

👍 Given the weirdness in mozilla/openbadges-backpack#1029 I fully support pushing this as is. We should talk in the Standard group about a modern 1.2-forward way of implementing embedded BadgeClasses and IssuerOrganizations.

@SueSmith SueSmith mentioned this pull request Jul 31, 2014
@kayaelle
Copy link

@cmcavoy when it's ready you can register the endpoint here: http://mozilla.github.io/openbadges-directory/#addbadges

And the badges should get indexed.

I'll get you an issue for backpack endpoint - apologies for delay.

@cmcavoy cmcavoy restored the 119-add-public-badge-list branch July 31, 2014 23:26
@kayaelle
Copy link

Hey @cmcavoy - Looking into why the badgekit badges aren't getting indexed. This url:

http://api.badgekit.org/public/badges
is returning this error:
{"code":"ResourceNotFound","message":"/public/badges does not exist"}

Is this correct endpoint url for the badgekit badges list?

Thanks

@ottonomy
Copy link

Did the merged code get deployed on badgekit.org?

On Wed, Aug 13, 2014 at 5:08 PM, kayaelle notifications@github.com wrote:

Hey @cmcavoy https://github.com/cmcavoy - Looking into why the badgekit
badges aren't getting indexed. This url:

http://api.badgekit.org/public/badges
is returning this error:
{"code":"ResourceNotFound","message":"/public/badges does not exist"}

Is this correct endpoint url for the badgekit badges list?

Thanks


Reply to this email directly or view it on GitHub
#120 (comment).

@SueSmith
Copy link
Contributor

Hi guys, wasn't this reverted because it had caused a bug? Looks like the endpoint is removed here #122

Apologies if I'm misunderstanding the problem! 😕

@kayaelle
Copy link

The last time I spoke to cmcavoy the endpoint had been merged and he registered it as an endpoint with the directory. The directory didn't index it. That was a couple of weeks ago. I only just had chance to look into the indexing issue and the url returned the error. Not clear on timing of when the endpoint was registered and #122. Can ask cmcavoy when he gets back. No urgency on it. Thanks!

On Aug 14, 2014, at 5:28 AM, Sue Smith notifications@github.com wrote:

Hi guys, wasn't this reverted because it had caused a bug? Looks like the endpoint is removed here #122

Apologies if I'm misunderstanding the problem!


Reply to this email directly or view it on GitHub.


server.get('/public/badges', [
function(req, res, next) {
badgeListName = "badgelist"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like the first time you hit this route, you change badgeListName to "badgelist", and all subsequent calls to showAllBadges will now send back data under "badgelist" instead of under "badges".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants