Skip to content

Commit

Permalink
Update checks.sql for android_app_campaign_stats_v1 since this was ch…
Browse files Browse the repository at this point in the history 
…anged to run incrementally (#6610)

* Update checks.sql

* Change ownership from Frank to Katie for DAG

* Update dags.yaml
  • Loading branch information
@kwindau
kwindau authored Dec 5, 2024
1 parent a9c3a72 commit 08fd28a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions dags.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -974,11 +974,11 @@ bqetl_fivetran_google_ads:
depends_on_past: false
email:
- telemetry-alerts@mozilla.com
- frank@mozilla.com
- kwindau@mozilla.com
email_on_failure: true
email_on_retry: true
email_on_retry: false
end_date: null
owner: frank@mozilla.com
owner: kwindau@mozilla.com
retries: 2
retry_delay: 30m
start_date: '2023-01-01'
Expand Down
2 changes: 1 addition & 1 deletion sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/checks.sql
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#fail
{{ is_unique(["date", "campaign", "ad_group"]) }}
{{ is_unique(["date", "campaign", "ad_group"], "date = DATE_SUB(@submission_date, INTERVAL 27 DAY)") }}

1 comment on commit 08fd28a

@dataops-ci-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration report for "Update checks.sql for android_app_campaign_stats_v1 since this was changed to run incrementally (#6610)"

sql.diff

Click to expand! 
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/dags/bqetl_fivetran_google_ads.py /tmp/workspace/generated-sql/dags/bqetl_fivetran_google_ads.py
--- /tmp/workspace/main-generated-sql/dags/bqetl_fivetran_google_ads.py	2024-12-05 15:52:49.000000000 +0000
+++ /tmp/workspace/generated-sql/dags/bqetl_fivetran_google_ads.py	2024-12-05 15:54:34.000000000 +0000
@@ -19,7 +19,7 @@
 Queries for Google Ads data coming from Fivetran. Fivetran updates these tables every hour.
 #### Owner
 
-frank@mozilla.com
+kwindau@mozilla.com
 
 #### Tags
 
@@ -29,14 +29,14 @@
 
 
 default_args = {
-    "owner": "frank@mozilla.com",
+    "owner": "kwindau@mozilla.com",
     "start_date": datetime.datetime(2023, 1, 1, 0, 0),
     "end_date": None,
-    "email": ["telemetry-alerts@mozilla.com", "frank@mozilla.com"],
+    "email": ["telemetry-alerts@mozilla.com", "kwindau@mozilla.com"],
     "depends_on_past": False,
     "retry_delay": datetime.timedelta(seconds=1800),
     "email_on_failure": True,
-    "email_on_retry": True,
+    "email_on_retry": False,
     "retries": 2,
 }
 
@@ -79,11 +79,7 @@
         table_id="moz-fx-data-shared-prod.google_ads_derived.android_app_campaign_stats_v1",
         warehouse_id="1939",
         owner="kwindau@mozilla.com",
-        email=[
-            "frank@mozilla.com",
-            "kwindau@mozilla.com",
-            "telemetry-alerts@mozilla.com",
-        ],
+        email=["kwindau@mozilla.com", "telemetry-alerts@mozilla.com"],
         depends_on_past=False,
         retries=0,
     )
@@ -95,7 +91,11 @@
         project_id="moz-fx-data-shared-prod",
         is_dq_check_fail=True,
         owner="frank@mozilla.com",
-        email=["frank@mozilla.com", "telemetry-alerts@mozilla.com"],
+        email=[
+            "frank@mozilla.com",
+            "kwindau@mozilla.com",
+            "telemetry-alerts@mozilla.com",
+        ],
         depends_on_past=False,
         task_concurrency=1,
         retries=0,
@@ -108,11 +108,7 @@
         project_id="moz-fx-data-shared-prod",
         is_dq_check_fail=True,
         owner="kwindau@mozilla.com",
-        email=[
-            "frank@mozilla.com",
-            "kwindau@mozilla.com",
-            "telemetry-alerts@mozilla.com",
-        ],
+        email=["kwindau@mozilla.com", "telemetry-alerts@mozilla.com"],
         depends_on_past=False,
         parameters=["date:DATE:{{macros.ds_add(ds, -27)}}"]
         + ["submission_date:DATE:{{ds}}"],
@@ -126,7 +122,11 @@
         project_id="moz-fx-data-shared-prod",
         is_dq_check_fail=True,
         owner="frank@mozilla.com",
-        email=["frank@mozilla.com", "telemetry-alerts@mozilla.com"],
+        email=[
+            "frank@mozilla.com",
+            "kwindau@mozilla.com",
+            "telemetry-alerts@mozilla.com",
+        ],
         depends_on_past=False,
         task_concurrency=1,
         retries=0,
@@ -139,7 +139,11 @@
         project_id="moz-fx-data-shared-prod",
         is_dq_check_fail=True,
         owner="frank@mozilla.com",
-        email=["frank@mozilla.com", "telemetry-alerts@mozilla.com"],
+        email=[
+            "frank@mozilla.com",
+            "kwindau@mozilla.com",
+            "telemetry-alerts@mozilla.com",
+        ],
         depends_on_past=False,
         task_concurrency=1,
         retries=0,
@@ -151,7 +155,11 @@
         dataset_id="google_ads_derived",
         project_id="moz-fx-data-shared-prod",
         owner="frank@mozilla.com",
-        email=["frank@mozilla.com", "telemetry-alerts@mozilla.com"],
+        email=[
+            "frank@mozilla.com",
+            "kwindau@mozilla.com",
+            "telemetry-alerts@mozilla.com",
+        ],
         date_partition_parameter=None,
         depends_on_past=False,
         task_concurrency=1,
@@ -163,7 +171,11 @@
         dataset_id="google_ads_derived",
         project_id="moz-fx-data-shared-prod",
         owner="frank@mozilla.com",
-        email=["frank@mozilla.com", "telemetry-alerts@mozilla.com"],
+        email=[
+            "frank@mozilla.com",
+            "kwindau@mozilla.com",
+            "telemetry-alerts@mozilla.com",
+        ],
         date_partition_parameter=None,
         depends_on_past=False,
         task_concurrency=1,
@@ -175,11 +187,7 @@
         dataset_id="google_ads_derived",
         project_id="moz-fx-data-shared-prod",
         owner="kwindau@mozilla.com",
-        email=[
-            "frank@mozilla.com",
-            "kwindau@mozilla.com",
-            "telemetry-alerts@mozilla.com",
-        ],
+        email=["kwindau@mozilla.com", "telemetry-alerts@mozilla.com"],
         date_partition_parameter=None,
         depends_on_past=False,
         parameters=["date:DATE:{{macros.ds_add(ds, -27)}}"]
@@ -192,7 +200,11 @@
         dataset_id="google_ads_derived",
         project_id="moz-fx-data-shared-prod",
         owner="frank@mozilla.com",
-        email=["frank@mozilla.com", "telemetry-alerts@mozilla.com"],
+        email=[
+            "frank@mozilla.com",
+            "kwindau@mozilla.com",
+            "telemetry-alerts@mozilla.com",
+        ],
         date_partition_parameter=None,
         depends_on_past=False,
         task_concurrency=1,
@@ -204,7 +216,11 @@
         dataset_id="google_ads_derived",
         project_id="moz-fx-data-shared-prod",
         owner="frank@mozilla.com",
-        email=["frank@mozilla.com", "telemetry-alerts@mozilla.com"],
+        email=[
+            "frank@mozilla.com",
+            "kwindau@mozilla.com",
+            "telemetry-alerts@mozilla.com",
+        ],
         date_partition_parameter=None,
         depends_on_past=False,
         task_concurrency=1,
@@ -230,7 +246,11 @@
         dataset_id="google_ads_derived",
         project_id="moz-fx-data-shared-prod",
         owner="frank@mozilla.com",
-        email=["frank@mozilla.com", "telemetry-alerts@mozilla.com"],
+        email=[
+            "frank@mozilla.com",
+            "kwindau@mozilla.com",
+            "telemetry-alerts@mozilla.com",
+        ],
         date_partition_parameter=None,
         depends_on_past=False,
         task_concurrency=1,
@@ -242,7 +262,11 @@
         dataset_id="google_ads_derived",
         project_id="moz-fx-data-shared-prod",
         owner="frank@mozilla.com",
-        email=["frank@mozilla.com", "telemetry-alerts@mozilla.com"],
+        email=[
+            "frank@mozilla.com",
+            "kwindau@mozilla.com",
+            "telemetry-alerts@mozilla.com",
+        ],
         date_partition_parameter=None,
         depends_on_past=False,
         task_concurrency=1,
@@ -254,7 +278,11 @@
         dataset_id="google_ads_derived",
         project_id="moz-fx-data-shared-prod",
         owner="frank@mozilla.com",
-        email=["frank@mozilla.com", "telemetry-alerts@mozilla.com"],
+        email=[
+            "frank@mozilla.com",
+            "kwindau@mozilla.com",
+            "telemetry-alerts@mozilla.com",
+        ],
         date_partition_parameter=None,
         depends_on_past=False,
         task_concurrency=1,
@@ -266,7 +294,11 @@
         dataset_id="google_ads_derived",
         project_id="moz-fx-data-shared-prod",
         owner="frank@mozilla.com",
-        email=["frank@mozilla.com", "telemetry-alerts@mozilla.com"],
+        email=[
+            "frank@mozilla.com",
+            "kwindau@mozilla.com",
+            "telemetry-alerts@mozilla.com",
+        ],
         date_partition_parameter=None,
         depends_on_past=False,
         task_concurrency=1,
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/apple_ads_external/ios_app_campaign_stats_v1/bigconfig.yml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/apple_ads_external/ios_app_campaign_stats_v1/bigconfig.yml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/apple_ads_external/ios_app_campaign_stats_v1/bigconfig.yml	2024-12-05 15:47:22.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/apple_ads_external/ios_app_campaign_stats_v1/bigconfig.yml	2024-12-05 15:51:24.000000000 +0000
@@ -1,7 +1,6 @@
 type: BIGCONFIG_FILE
-
 tag_deployments:
-  - collection:
+- collection:
       name: Growth Program
       notification_channels:
         - slack: '#ds-bigeye-triage'
@@ -20,8 +19,7 @@
         metrics:
           - saved_metric_id: freshness
           - saved_metric_id: volume
-
-  - collection:
+- collection:
       name: Operational Checks
       notification_channels:
         - slack: '#de-bigeye-triage'
@@ -31,3 +29,21 @@
         metrics:
           - saved_metric_id: freshness
           - saved_metric_id: volume
+- deployments:
+  - column_selectors:
+    - name: moz-fx-data-shared-prod.moz-fx-data-shared-prod.apple_ads_external.ios_app_campaign_stats_v1.*
+    metrics:
+    - metric_type:
+        type: PREDEFINED
+        predefined_metric: FRESHNESS
+      metric_name: FRESHNESS [warn]
+      metric_schedule:
+        named_schedule:
+          name: Default Schedule - 13:00 UTC
+    - metric_type:
+        type: PREDEFINED
+        predefined_metric: VOLUME
+      metric_name: VOLUME [fail]
+      metric_schedule:
+        named_schedule:
+          name: Default Schedule - 13:00 UTC
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/checks.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/checks.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/checks.sql	2024-12-05 15:47:23.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/google_ads_derived/android_app_campaign_stats_v1/checks.sql	2024-12-05 15:47:31.000000000 +0000
@@ -1,2 +1,2 @@
 #fail
-{{ is_unique(["date", "campaign", "ad_group"]) }}
+{{ is_unique(["date", "campaign", "ad_group"], "date = DATE_SUB(@submission_date, INTERVAL 27 DAY)") }}

Link to full diff

Please sign in to comment.