From cbe0b8ea3e4c7c378c3c3bd8721623add9b88c96 Mon Sep 17 00:00:00 2001 From: Nika Layzell Date: Fri, 20 Dec 2024 13:08:31 -0500 Subject: [PATCH] Fix new clippy failures --- src/format.rs | 6 +++--- src/git_tool.rs | 2 +- src/out.rs | 2 +- src/resolver.rs | 10 +++++----- tests/snapshots/test_cli__test-project-suggest.snap | 4 ++-- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/format.rs b/src/format.rs index 5b0f3bb0..05ab7ee6 100644 --- a/src/format.rs +++ b/src/format.rs @@ -136,7 +136,7 @@ impl<'de> Deserialize<'de> for VetVersion { { struct VersionVisitor; - impl<'de> Visitor<'de> for VersionVisitor { + impl Visitor<'_> for VersionVisitor { type Value = VetVersion; fn expecting(&self, f: &mut fmt::Formatter) -> fmt::Result { @@ -441,7 +441,7 @@ impl<'de> Deserialize<'de> for Delta { { struct DeltaVisitor; - impl<'de> Visitor<'de> for DeltaVisitor { + impl Visitor<'_> for DeltaVisitor { type Value = Delta; fn expecting(&self, f: &mut fmt::Formatter) -> fmt::Result { @@ -972,7 +972,7 @@ impl<'de> Deserialize<'de> for StoreVersion { { struct VersionVisitor; - impl<'de> Visitor<'de> for VersionVisitor { + impl Visitor<'_> for VersionVisitor { type Value = StoreVersion; fn expecting(&self, f: &mut fmt::Formatter) -> fmt::Result { diff --git a/src/git_tool.rs b/src/git_tool.rs index 08de4002..344d8b7e 100644 --- a/src/git_tool.rs +++ b/src/git_tool.rs @@ -343,7 +343,7 @@ impl<'a> Pager<'a> { } } -impl<'a> io::Write for Pager<'a> { +impl io::Write for Pager<'_> { fn write(&mut self, buf: &[u8]) -> io::Result { match &mut self.child { Some(child) => child.stdin.as_mut().unwrap().write(buf), diff --git a/src/out.rs b/src/out.rs index d6e3f140..db3dc3e4 100644 --- a/src/out.rs +++ b/src/out.rs @@ -20,7 +20,7 @@ pub trait Out: Send + Sync + 'static { /// Write to the output fn write_fmt(&self, args: fmt::Arguments<'_>) { struct AsWrite<'a, T: ?Sized>(&'a T); - impl<'a, T: ?Sized + Out> io::Write for AsWrite<'a, T> { + impl io::Write for AsWrite<'_, T> { fn write(&mut self, buf: &[u8]) -> io::Result { Out::write(self.0, buf) } diff --git a/src/resolver.rs b/src/resolver.rs index ca74d46a..14f383bf 100644 --- a/src/resolver.rs +++ b/src/resolver.rs @@ -1543,18 +1543,18 @@ fn search_for_path( } } } - impl<'a> PartialEq for Node<'a> { + impl PartialEq for Node<'_> { fn eq(&self, other: &Self) -> bool { self.key() == other.key() } } - impl<'a> Eq for Node<'a> {} - impl<'a> PartialOrd for Node<'a> { + impl Eq for Node<'_> {} + impl PartialOrd for Node<'_> { fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } } - impl<'a> Ord for Node<'a> { + impl Ord for Node<'_> { fn cmp(&self, other: &Self) -> std::cmp::Ordering { self.key().cmp(&other.key()) } @@ -1665,7 +1665,7 @@ fn search_for_path( Err(visited.into_iter().map(|v| v.cloned()).collect()) } -impl<'a> ResolveReport<'a> { +impl ResolveReport<'_> { pub fn has_errors(&self) -> bool { // Just check the conclusion !matches!(self.conclusion, Conclusion::Success(_)) diff --git a/tests/snapshots/test_cli__test-project-suggest.snap b/tests/snapshots/test_cli__test-project-suggest.snap index 9526a0d9..f1100eee 100644 --- a/tests/snapshots/test_cli__test-project-suggest.snap +++ b/tests/snapshots/test_cli__test-project-suggest.snap @@ -60,7 +60,7 @@ recommended audits for safe-to-deploy (or audited): cargo vet inspect winreg 0.10.1 gentoo90 reqwest 3920 lines cargo vet inspect core-foundation 0.9.3 jrmuizel security-framework 3953 lines cargo vet inspect tracing-attributes 0.1.20 hawkw tracing 3957 lines - NOTE: this project trusts Eliza Weisman (hawkw) - consider cargo vet trust tracing-attributes or cargo vet trust --all hawkw + NOTE: this project trusts Eliza Weisman (hawkw) - consider cargo vet trust tracing-attributes hawkw cargo vet inspect ipnet 2.4.0 krisprice reqwest 3973 lines cargo vet inspect futures-channel 0.3.21 taiki-e hyper 3992 lines cargo vet inspect tempfile 3.3.0 Stebalien native-tls 4059 lines @@ -72,7 +72,7 @@ recommended audits for safe-to-deploy (or audited): cargo vet inspect socket2 0.4.4 Thomasdezeeuw hyper and tokio 6011 lines cargo vet inspect pin-project-lite 0.2.8 taiki-e hyper, tokio, reqwest, and 4 others 6100 lines cargo vet inspect tracing-core 0.1.25 hawkw tracing 6156 lines - NOTE: this project trusts Eliza Weisman (hawkw) - consider cargo vet trust tracing-core or cargo vet trust --all hawkw + NOTE: this project trusts Eliza Weisman (hawkw) - consider cargo vet trust tracing-core hawkw cargo vet inspect cc 1.0.73 alexcrichton openssl-sys 6554 lines cargo vet inspect httparse 1.7.0 seanmonstar hyper 7258 lines cargo vet inspect memchr 2.4.1 BurntSushi tokio and os_str_bytes 8712 lines