Fix "Attempt to overwrite '*' in LogRecord" #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abpostelnicu
approved these changes
Aug 16, 2022
Contributor
|
Thank you! We might be able to do a release after this :) |
marco-c
added a commit
to marco-c/code-coverage
that referenced
this pull request
Mar 9, 2023
Fixes mozilla#1521 by bringing in the changes from: - mozilla/code-review#1253 - mozilla/code-review#1276 - mozilla/code-review#1333 - mozilla/code-review#1365
marco-c
added a commit
to marco-c/code-coverage
that referenced
this pull request
Mar 9, 2023
Fixes mozilla#1521 by bringing in the changes from: - mozilla/code-review#1253 - mozilla/code-review#1276 - mozilla/code-review#1333 - mozilla/code-review#1365
marco-c
added a commit
to mozilla/code-coverage
that referenced
this pull request
Mar 9, 2023
* Use sentry_sdk instead of raven and improve Sentry grouping Fixes #1521 by bringing in the changes from: - mozilla/code-review#1253 - mozilla/code-review#1276 - mozilla/code-review#1333 - mozilla/code-review#1365 * Rename sentry_dsn parameter to SENTRY_DSN to match the name in code-review and reduce code differences between the log.py files
marco-c
added a commit
to mozilla/code-coverage
that referenced
this pull request
Mar 9, 2023
* Use sentry_sdk instead of raven and improve Sentry grouping Fixes #1521 by bringing in the changes from: - mozilla/code-review#1253 - mozilla/code-review#1276 - mozilla/code-review#1333 - mozilla/code-review#1365 * Rename sentry_dsn parameter to SENTRY_DSN to match the name in code-review and reduce code differences between the log.py files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that appeared after merging #1253, that raises an error
Attempt to overwrite '*' in LogRecord(with*, a common attribute fromLogRecord) when several logs were processed bystructlogprocessors.In
loggingdocumentation:The line raising the error in
logging:https://hg.python.org/cpython/file/3.5/Lib/logging/__init__.py#l1394
The quick fix implemented in this PR is to rename all clashing attributes by adding a
_character.