Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework libcubeb vendoring. #111

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Rework libcubeb vendoring. #111

merged 1 commit into from
Dec 10, 2024

Conversation

kinetiknz
Copy link
Contributor

cubeb-rs releases are now to be performed using cargo xtask release.

This is a hack to allow us to ship a vendored copy of libcubeb including libcubeb's Rust crates. cargo publish excludes all subdirectories that contain a Cargo.toml, preventing a complete vendoring of libcubeb.

The release xtask recursively renames Cargo.toml -> Cargo.toml.in before running cargo release and cargo publish, then renames them back.

build.rs now always builds using $OUT_DIR/libcubeb, copying and renaming Cargo.toml.in as necessary.

cubeb-rs releases are now to be performed using `cargo xtask release`.

This is a hack to allow us to ship a vendored copy of libcubeb *including*
libcubeb's Rust crates.  `cargo publish` excludes all subdirectories that
contain a `Cargo.toml`, preventing a complete vendoring of libcubeb.

The release xtask recursively renames `Cargo.toml` -> `Cargo.toml.in` before
running `cargo release` and `cargo publish`, then renames them back.

build.rs now always builds using $OUT_DIR/libcubeb, copying and renaming
`Cargo.toml.in` as necessary.
@kinetiknz kinetiknz merged commit 21a8086 into master Dec 10, 2024
10 of 14 checks passed
@kinetiknz kinetiknz deleted the xtask branch December 10, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant