-
Notifications
You must be signed in to change notification settings - Fork 22
Expose async logging for backends #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure why this isn't building... I've been testing with |
|
Glad to see you are making progress! I guess the corresponding cubeb changes (to expose |
…available, both to fix build errors
…tead of kinetik's
cubeb-backend/src/log.rs
Outdated
| cstr | ||
| } | ||
|
|
||
| match($use_async) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since $use_async is an ident, could we use a literal for $use_async to distinguish whether the call is an async log or not (see https://doc.rust-lang.org/reference/macros-by-example.html#transcribing), which should have better readability? What do you think?
ffi::cubeb_async_log. See also: ashleyz's cubeb async_logging branch changes.
|
Build errors in nightly should be fixed with PR #72 |
|
Related PR: mozilla/cubeb#714 Related WIP branch to use async calls with PulseAudio: ashleyz/cubeb-pulse-rs |
kinetiknz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Patch to expose async logging for backends. Adds
cubeb_alog!/cubeb_alogv!macros to make use of it.