Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graceful shutdown not supported #9686

Closed
data-sync-user opened this issue Jun 21, 2021 · 6 comments
Closed

Graceful shutdown not supported #9686

data-sync-user opened this issue Jun 21, 2021 · 6 comments

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jun 21, 2021

Description

In case of deployments that need to support zero-downtime, the support of graceful shutdown methods is essential, so that in-process requests can finish processing while new requests are being rejected.

Major runtime environments have settled for using SIGTERM as the default signal for a graceful shutdown:

Although pm2 uses SIGINT by default, that also does not seem to be supported by many services.

Steps to reproduce

  1. start a Docker container or the intended local server process of an affected service
  2. send signal TERM to the process

Expected result

Server process shuts down gracefully with with exit code 0.

Actual result

Nothing happens. Server process keeps running.

Environment

not applicable

┆Issue is synchronized with this Jira Task

@data-sync-user
Copy link
Collaborator Author

➤ Kane commented:

At least the following services currently do not support SIGTERM:

@data-sync-user
Copy link
Collaborator Author

➤ Jody Heavener commented:

Looks like this closed in #5938

@data-sync-user
Copy link
Collaborator Author

➤ Kane commented:

@jodyheavener
Actually, at least the email-service still doesn't support this, but that seems to be a longer story with Rocket:

Also, I didn't check all services, e.g. admin/support/payment. But for those, separate PR's would be better than to keep issues open for too long.

@data-sync-user
Copy link
Collaborator Author

➤ Jody Heavener commented:

Ah, ok noted. Thanks for the heads up.

@data-sync-user
Copy link
Collaborator Author

➤ Kane commented:

Finally looked through all services and I think #5961 is now ready for review.

@cknowles-admin
Copy link

FxA is no longer synchronizing all issues between Jira and Github. We are closing open issues and will selectively synchronize in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants