-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graceful shutdown not supported #9686
Comments
➤ Kane commented: At least the following services currently do not support SIGTERM: |
➤ Jody Heavener commented: Looks like this closed in #5938 |
➤ Kane commented: @jodyheavener Also, I didn't check all services, e.g. admin/support/payment. But for those, separate PR's would be better than to keep issues open for too long. |
➤ Jody Heavener commented: Ah, ok noted. Thanks for the heads up. |
➤ Kane commented: Finally looked through all services and I think #5961 is now ready for review. |
FxA is no longer synchronizing all issues between Jira and Github. We are closing open issues and will selectively synchronize in the future. |
Description
In case of deployments that need to support zero-downtime, the support of graceful shutdown methods is essential, so that in-process requests can finish processing while new requests are being rejected.
Major runtime environments have settled for using
SIGTERM
as the default signal for a graceful shutdown:docker stop
Although
pm2
usesSIGINT
by default, that also does not seem to be supported by many services.Steps to reproduce
Expected result
Server process shuts down gracefully with with exit code
0
.Actual result
Nothing happens. Server process keeps running.
Environment
not applicable
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: