Bug 1221097 - Implement device registration for Firefox Accounts #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| log.debug("setSignedInUser"); | ||
| let existingDeviceId; | ||
| return this.getSignedInUser().then(currentUserData => { |
There was a problem hiding this comment.
@philbooth if getSignedInUser fails for some odd reason then would we be blocking the rest of the flow here?
Should we proceed to let currentAccountState below even if there is an error here (or promise rejects)?
There was a problem hiding this comment.
As it happens, this bit's completely changed in the branch I'm currently working in. See:
There's a couple of issues with it that I'm still working on though, which is why I haven't mentioned it properly yet.
This reverts commit d37b200c319576263cc119b9f38f54724595b81f.
nchevobbe
added a commit
to nchevobbe/gecko-dev
that referenced
this pull request
Apr 29, 2016
…ter names (mozilla#75) * Rename temporary variables and components with better names
moz-v2v-gh
pushed a commit
that referenced
this pull request
Jul 29, 2016
This addresses two crashes in the top #75 on 47.0.1.
JamesWCCheng
pushed a commit
to JamesWCCheng/gecko-dev
that referenced
this pull request
Aug 1, 2016
This addresses two crashes in the top mozilla#75 on 47.0.1.
jryans
pushed a commit
to jryans/gecko-dev
that referenced
this pull request
Aug 5, 2016
This addresses two crashes in the top mozilla#75 on 47.0.1.
moz-v2v-gh
pushed a commit
that referenced
this pull request
Aug 12, 2016
…lizzard This addresses two crashes in the top #75 on 47.0.1. --HG-- extra : source : 19c9fa346278d7fabd7a4dfebd4cee0c263ec551
moz-v2v-gh
pushed a commit
that referenced
this pull request
Sep 3, 2017
Update version number for release Source-Repo: https://github.com/mozilla/webdriver-rust Source-Revision: 87bbf8cf0808752b92b40d5f5befff38dde6d601 --HG-- extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000 extra : subtree_revision : 05efaf2baf96b24664277c1768dcdd2ea32bbf43
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this pull request
Sep 4, 2017
Update version number for release Source-Repo: https://github.com/mozilla/webdriver-rust Source-Revision: 87bbf8cf0808752b92b40d5f5befff38dde6d601
daoshengmu
pushed a commit
to daoshengmu/gecko-dev
that referenced
this pull request
Sep 8, 2017
Update version number for release Source-Repo: https://github.com/mozilla/webdriver-rust Source-Revision: 87bbf8cf0808752b92b40d5f5befff38dde6d601
moz-v2v-gh
pushed a commit
that referenced
this pull request
Apr 2, 2020
Pick commits: - 432259a: Run `cargo fmt` - c9f0499: Revert `derive(Debug)` removal (#75) - f9abca8: Replace the custom input linear buffer by something based on ringbuf. (#74) - 4eafcc8: Fix the resampler-calling code to use the correct semantic (#71) - 828efbc: Merge pull request #72 from ChunMinChang/rm-debug-trait Differential Revision: https://phabricator.services.mozilla.com/D69250 --HG-- extra : moz-landing-system : lando
bvaughn
pushed a commit
to bvaughn/gecko-dev
that referenced
this pull request
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo Authors: Ignore this PR we are just using it to collaborate
Will close after Bugzilla patch lands