From bce13a8ba3ac9ee123ff9568f48e372ff81da975 Mon Sep 17 00:00:00 2001 From: Jan-Erik Rediger Date: Wed, 3 Aug 2022 10:13:58 +0200 Subject: [PATCH] Remove superfluous overload attribute These don't have an effect on methods without defaults. This is a compiler warning, which we failed to get rid of. --- .../main/java/mozilla/telemetry/glean/private/EventMetricType.kt | 1 - .../java/mozilla/telemetry/glean/private/LabeledMetricType.kt | 1 - 2 files changed, 2 deletions(-) diff --git a/glean-core/android/src/main/java/mozilla/telemetry/glean/private/EventMetricType.kt b/glean-core/android/src/main/java/mozilla/telemetry/glean/private/EventMetricType.kt index 9d51e88dd3..afb5447818 100644 --- a/glean-core/android/src/main/java/mozilla/telemetry/glean/private/EventMetricType.kt +++ b/glean-core/android/src/main/java/mozilla/telemetry/glean/private/EventMetricType.kt @@ -129,6 +129,5 @@ class EventMetricType internal constructor( * @return the number of errors recorded for the metric. */ @VisibleForTesting(otherwise = VisibleForTesting.NONE) - @JvmOverloads fun testGetNumRecordedErrors(errorType: ErrorType) = inner.testGetNumRecordedErrors(errorType) } diff --git a/glean-core/android/src/main/java/mozilla/telemetry/glean/private/LabeledMetricType.kt b/glean-core/android/src/main/java/mozilla/telemetry/glean/private/LabeledMetricType.kt index 44f7451982..f5dfed24b9 100644 --- a/glean-core/android/src/main/java/mozilla/telemetry/glean/private/LabeledMetricType.kt +++ b/glean-core/android/src/main/java/mozilla/telemetry/glean/private/LabeledMetricType.kt @@ -111,7 +111,6 @@ class LabeledMetricType( * @return the number of errors recorded for the metric. */ @VisibleForTesting(otherwise = VisibleForTesting.NONE) - @JvmOverloads fun testGetNumRecordedErrors(errorType: ErrorType): Int { return when (this.inner) { is LabeledCounter -> this.inner.testGetNumRecordedErrors(errorType)