From f5aa432fcb608e6a07fa5d71368f68c99aeb6d84 Mon Sep 17 00:00:00 2001 From: Jan-Erik Rediger Date: Mon, 19 Sep 2022 10:45:32 +0200 Subject: [PATCH] Use single-quote to ensure code is valid when executed on Windows --- CHANGELOG.md | 3 +++ .../telemetry/glean-gradle-plugin/GleanGradlePlugin.groovy | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 193bd2e34c..5970bf2abd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ [Full changelog](https://github.com/mozilla/glean/compare/v51.2.0...main) +* Kotlin + * Gradle plugin: Fix quoting issue in Python wrapper code ([#2193](https://github.com/mozilla/glean/pull/2193)) + # v51.2.0 (2022-09-08) [Full changelog](https://github.com/mozilla/glean/compare/v51.1.0...v51.2.0) diff --git a/gradle-plugin/src/main/groovy/mozilla/telemetry/glean-gradle-plugin/GleanGradlePlugin.groovy b/gradle-plugin/src/main/groovy/mozilla/telemetry/glean-gradle-plugin/GleanGradlePlugin.groovy index b7080c2fb5..45f4d2f2ac 100644 --- a/gradle-plugin/src/main/groovy/mozilla/telemetry/glean-gradle-plugin/GleanGradlePlugin.groovy +++ b/gradle-plugin/src/main/groovy/mozilla/telemetry/glean-gradle-plugin/GleanGradlePlugin.groovy @@ -104,9 +104,9 @@ else: sys.exit(1) else: # We check MAJOR.MINOR only - expected_ver = expected_version.split(".") + expected_ver = expected_version.split('.') expected_maj, expected_min = int(expected_ver[0]), int(expected_ver[1]) - current_ver = found_version.split(".") + current_ver = found_version.split('.') current_maj, current_min = int(current_ver[0]), int(current_ver[1]) if current_maj > expected_maj or current_maj < expected_maj or (current_maj == expected_maj and current_min < expected_min):