Bug 1597761 - Don't create PingRequest if body exceeds 1MB #1098
Conversation
There was a problem hiding this comment.
Good start.
See inline comments, mostly about being explicit about the units we use.
We should probably also document that we discard pings bigger than 1 Mb (and that this applies to after compression).
@Dexterp37 What would be a good place to document our guarantees around pings? Do we already have something (e.g. for the rate limiting)?
For the rate limiting we have a note on the internal documentation: https://mozilla.github.io/glean/book/dev/core/internal/upload.html?highlight=rate,limiting#1 and another note on the "Pings" page: https://mozilla.github.io/glean/book/user/pings/index.html?highlight=rate#ping-submission. We could maybe create a "Limitations" section on the "Pings" page, under the "Ping submission" section to list both in a more structured manner. |
@badboy @brizental I think the above is a good idea! |
* Use usize instead of u64 in PingBodyOverflow error; * Be explicit about bytes unit in ping body size comments; * Consume pending_pings array in correct order; * Use meaningful value for body_max_size request tests;
Also... * Correct data-review link for discarded_exceeding_pings_size * Add changelog entry about ping tagging for iOS (forgot on previous PR)
brizental
force-pushed
the
1597761-one-mb-pings
branch
from
9fce297 to
ff3c52c
Compare
| * General | ||
| * Limit ping request body size to 1MB. ([#1098](https://github.com/mozilla/glean/pull/1098)) | ||
| * iOS | ||
| * Implement ping tagging (i.e. the `X-Source-Tags` header) through custom URL ([#1100](https://github.com/mozilla/glean/pull/1100)). |
There was a problem hiding this comment.
:D was that missed in that PR? Good to still get it in.
There was a problem hiding this comment.
Yeap, I am trying to remind myself everytime, but still miss it sometimes.
This required a bit more changes than I expected because of the need to record metrics.
Data review for the metrics recorded here is still ongoing.