diff --git a/generator/views/funnel_analysis_view.py b/generator/views/funnel_analysis_view.py index 3262165f..4bb6a501 100644 --- a/generator/views/funnel_analysis_view.py +++ b/generator/views/funnel_analysis_view.py @@ -165,8 +165,10 @@ def _event_types_lookml(self) -> List[Dict[str, Any]]: SELECT mozfun.event_analysis.aggregate_match_strings( ARRAY_AGG( - CONCAT( + DISTINCT CONCAT( + {{% if _filters['property_name'] or _filters['property_value'] -%}} COALESCE(mozfun.event_analysis.escape_metachars(property_value.value), ''), + {{% endif -%}} mozfun.event_analysis.event_index_to_match_string(et.index) ) ) diff --git a/tests/test_funnel_analysis.py b/tests/test_funnel_analysis.py index 3aa8ec83..496906a6 100644 --- a/tests/test_funnel_analysis.py +++ b/tests/test_funnel_analysis.py @@ -178,8 +178,10 @@ def test_view_lookml(funnel_analysis_view): SELECT mozfun.event_analysis.aggregate_match_strings( ARRAY_AGG( - CONCAT( + DISTINCT CONCAT( + {% if _filters['property_name'] or _filters['property_value'] -%} COALESCE(mozfun.event_analysis.escape_metachars(property_value.value), ''), + {% endif -%} mozfun.event_analysis.event_index_to_match_string(et.index) ) )