Add tabs count as template variable for titlebar customization #171
Conversation
|
Nice addition! Please implement the support of Thunderbird ( |
|
I don't use Thunderbird and SeaMonkey, so I won't be able to test it, so please implement it by yourself. |
|
Thanks for the contribution! I'll push your changes to a new branch in mozilla/nightlytt to implement the missing bits, and close this pull request. |
|
Pushed as branch Thanks again. Closing this. |
|
Even if we can get this only implemented for a single application, we should not push this to a temporary branch on the official repository but land it properly. |
| @@ -102,7 +102,7 @@ init: function(aEvent) | |||
| paneTitle.addVariable("Compiler"); | |||
| paneTitle.addVariable("Toolkit"); | |||
| paneTitle.addVariable("Profile"); | |||
|
|
|||
| paneTitle.addVariable("TabsCount"); | |||
There was a problem hiding this comment.
Can we get a new issue filed to get all of those variables sorted alphabetically?
There was a problem hiding this comment.
Can we get a new issue filed to get all of those variables sorted alphabetically?
Filed Issue #172.
whimboo
changed the title
|
This PR is not ready to land on the master branch even with an updated commit message, IMHO. |
|
If we leave SeaMonkey and Thunderbird broken the fix is not complete and should not be merged, right. @KOLANICH I think adding the code for both other applications should be easy to do. Also I think that @xabolcs and @tonymec would totally help out with testing. Would you mind to continue on this PR? |
Added tabs counter into titlebar