From ea1d090109512045e68833a8f2c5626142c25def Mon Sep 17 00:00:00 2001 From: Calixte Denizet Date: Mon, 13 Mar 2023 16:56:42 +0100 Subject: [PATCH] Remove tag from the Firefox built-in viewer (bug 1821408) The tag is used to resolve relative URIs within the document. Newly added SVG filters use a relative URI which then use the URI in base but this one mismatches with the document URI and consequently filters are not found in the Firefox viewer. So this patch just removes and replace few relative URLs by absolute ones. --- web/app_options.js | 3 +++ web/viewer-geckoview.html | 4 ++-- web/viewer-snippet-firefox-extension.html | 3 +-- web/viewer.html | 13 ++++++++++--- 4 files changed, 16 insertions(+), 7 deletions(-) diff --git a/web/app_options.js b/web/app_options.js index f0a5491e3bd31..79d8e5f619b24 100644 --- a/web/app_options.js +++ b/web/app_options.js @@ -284,8 +284,11 @@ const defaultOptions = { workerSrc: { /** @type {string} */ value: + // eslint-disable-next-line no-nested-ternary typeof PDFJSDev === "undefined" || !PDFJSDev.test("PRODUCTION") ? "../src/worker_loader.js" + : PDFJSDev.test("MOZCENTRAL") + ? "resource://pdf.js/build/pdf.worker.js" : "../build/pdf.worker.js", kind: OptionKind.WORKER, }, diff --git a/web/viewer-geckoview.html b/web/viewer-geckoview.html index f96eb3b951b7a..03f3f64b0746a 100644 --- a/web/viewer-geckoview.html +++ b/web/viewer-geckoview.html @@ -31,7 +31,7 @@ - + @@ -71,7 +71,7 @@ - + diff --git a/web/viewer-snippet-firefox-extension.html b/web/viewer-snippet-firefox-extension.html index b153febfa1d84..c7c416d503b57 100644 --- a/web/viewer-snippet-firefox-extension.html +++ b/web/viewer-snippet-firefox-extension.html @@ -1,3 +1,2 @@ - - + diff --git a/web/viewer.html b/web/viewer.html index 112083dbff61c..582c7ee4d6d64 100644 --- a/web/viewer.html +++ b/web/viewer.html @@ -36,7 +36,12 @@ + + + + + @@ -77,10 +82,12 @@ - - - + + + + +