From 9e352a8bad79b106d017ef7ae55a8ccce448b80f Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Sat, 6 Jul 2024 15:14:39 +0200
Subject: [PATCH] Move the "updatedPreference" event listener registration

This patch fixes a situation that'll probably never happen, but nonetheless seems like something that we should address.
Currently the "updatedPreference" listener isn't registered *until after* the preferences have been read and initialized, which leaves a very short window of time where a preference change could theoretically be skipped.
---
 web/preferences.js | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/web/preferences.js b/web/preferences.js
index d181d1add0960..944c0d84ba37f 100644
--- a/web/preferences.js
+++ b/web/preferences.js
@@ -67,16 +67,13 @@ class BasePreferences {
             typeof prefVal === typeof val ? prefVal : val;
         }
         AppOptions.setAll(options, /* init = */ true);
-
-        if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) {
-          window.addEventListener("updatedPreference", evt => {
-            this.#updatePref(evt.detail);
-          });
-        }
       }
     );
 
     if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) {
+      window.addEventListener("updatedPreference", evt => {
+        this.#updatePref(evt.detail);
+      });
       this.eventBus = null;
     }
   }
@@ -101,10 +98,11 @@ class BasePreferences {
     throw new Error("Not implemented: _readFromStorage");
   }
 
-  #updatePref({ name, value }) {
+  async #updatePref({ name, value }) {
     if (typeof PDFJSDev === "undefined" || !PDFJSDev.test("MOZCENTRAL")) {
       throw new Error("Not implemented: #updatePref");
     }
+    await this.#initializedPromise;
 
     if (name in this.#browserDefaults) {
       if (typeof value !== typeof this.#browserDefaults[name]) {