From f2b295882f19e8ff36e173eee7d2656dd5095b3f Mon Sep 17 00:00:00 2001 From: Dylan Lacey Date: Thu, 25 Jun 2020 13:54:54 +1000 Subject: [PATCH] Update Needle to 2.5.0 or greater. Versions of `needle` prior to `2.5.0` cannot cope with redirects (as documented: https://github.com/tomas/needle/issues/312). This prevents prebuilt `canvas` binaries from being downloaded on MacOS, requiring the global install of its dependencies. Updating Needle restores it to functionality, addressing this. It also avoids the need to add `request` to `package.json`; it also obsoletes https://github.com/mozilla/pdf.js/pull/12018. --- package-lock.json | 6 +++--- package.json | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index f7951b6a02972..6a12eb73daf66 100644 --- a/package-lock.json +++ b/package-lock.json @@ -8919,9 +8919,9 @@ "dev": true }, "needle": { - "version": "2.4.0", - "resolved": "https://registry.npmjs.org/needle/-/needle-2.4.0.tgz", - "integrity": "sha512-4Hnwzr3mi5L97hMYeNl8wRW/Onhy4nUKR/lVemJ8gJedxxUyBLm9kkrDColJvoSfwi0jCNhD+xCdOtiGDQiRZg==", + "version": "2.5.0", + "resolved": "https://registry.npmjs.org/needle/-/needle-2.5.0.tgz", + "integrity": "sha512-o/qITSDR0JCyCKEQ1/1bnUXMmznxabbwi/Y4WwJElf+evwJNFNwIDMCCt5IigFVxgeGBJESLohGtIS9gEzo1fA==", "dev": true, "requires": { "debug": "^3.2.6", diff --git a/package.json b/package.json index e87de5d0aaf0f..300f8404bf4bd 100644 --- a/package.json +++ b/package.json @@ -38,6 +38,7 @@ "jstransformer-markdown-it": "^2.1.0", "merge-stream": "^1.0.1", "mkdirp": "^1.0.4", + "needle": "^2.5.0", "postcss-calc": "^7.0.2", "postcss-css-variables": "^0.14.0", "prettier": "^2.0.5",