From 010d996b749f9aa40f5f1c81e6ca947846a91a1c Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 11 Jun 2022 11:33:43 +0200 Subject: [PATCH] Enable the `unicorn/prefer-array-flat` and `unicorn/prefer-array-flat-map` ESLint plugin rules These rules will help enforce shorter and more readable code, and according to MDN these Array-methods are available in all browsers/environments that we currently support: - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flat#browser_compatibility - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flatMap#browser_compatibility Please find additional information about these ESLint rules here: - https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-array-flat.md - https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-array-flat-map.md --- .eslintrc | 2 ++ src/core/xfa/som.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index ac3506b6d32e0..4d0c7af71ee03 100644 --- a/.eslintrc +++ b/.eslintrc @@ -49,6 +49,8 @@ "unicorn/no-new-buffer": "error", "unicorn/no-instanceof-array": "error", "unicorn/no-useless-spread": "error", + "unicorn/prefer-array-flat": "error", + "unicorn/prefer-array-flat-map": "error", "unicorn/prefer-at": "error", "unicorn/prefer-date-now": "error", "unicorn/prefer-dom-node-remove": "error", diff --git a/src/core/xfa/som.js b/src/core/xfa/som.js index 9015a81c4268f..02011b05aa744 100644 --- a/src/core/xfa/som.js +++ b/src/core/xfa/som.js @@ -254,7 +254,7 @@ function searchNode( if (isFinite(index)) { root = nodes.filter(node => index < node.length).map(node => node[index]); } else { - root = nodes.reduce((acc, node) => acc.concat(node), []); + root = nodes.flat(); } }