From 6d1f7e806e5df3a5dcc18145fc0f8db668a2896c Mon Sep 17 00:00:00 2001 From: Calixte Denizet Date: Fri, 14 Jun 2024 16:43:36 +0200 Subject: [PATCH] Fix an query with an empty selector in integration tests In looking the logs from Chrome bidi tests I noticed a js syntax error which is fixed thanks to this patch. --- test/integration/test_utils.mjs | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/test/integration/test_utils.mjs b/test/integration/test_utils.mjs index a282aaeeadd1f..9d230b5af9dbd 100644 --- a/test/integration/test_utils.mjs +++ b/test/integration/test_utils.mjs @@ -268,23 +268,18 @@ async function pasteFromClipboard(page, data, selector, timeout = 100) { const handle = await page.evaluateHandle( (sel, timeOut) => { let callback = null; + const element = sel ? document.querySelector(sel) : document; return [ Promise.race([ new Promise(resolve => { callback = e => resolve(e.clipboardData.items.length !== 0); - (sel ? document.querySelector(sel) : document).addEventListener( - "paste", - callback, - { - once: true, - } - ); + element.addEventListener("paste", callback, { + once: true, + }); }), new Promise(resolve => { setTimeout(() => { - document - .querySelector(sel) - .removeEventListener("paste", callback); + element.removeEventListener("paste", callback); resolve(false); }, timeOut); }),