Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly compute the mapping between text and normalized text when it contains a compound word on two lines #19122

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

calixteman
Copy link
Contributor

It fixes #19120.

The original text doesn't contain the cr so we must take that into account.

…t contains a compound word on two lines

It fixes mozilla#19120.

The original text doesn't contain the cr so we must take that into account.
@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/c8a4d120c60d06f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/3458d121ecb4d51/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/c8a4d120c60d06f/output.txt

Total script time: 2.58 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/3458d121ecb4d51/output.txt

Total script time: 6.79 mins

  • Unit Tests: Passed

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@calixteman calixteman merged commit c784a24 into mozilla:master Nov 28, 2024
7 checks passed
@calixteman calixteman deleted the issue19120 branch November 28, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants