Skip to content

Add few methods to the Dict class in order to simplify the code when writing an annotation #20064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

Add few methods to the Dict class in order to simplify the code when writing an annotation #20064

merged 1 commit into from
Jul 8, 2025

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Jul 7, 2025

No description provided.

@calixteman calixteman requested a review from timvandermeij July 7, 2025 18:40
@calixteman
Copy link
Contributor Author

calixteman commented Jul 7, 2025

/botio unittest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jul 7, 2025

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6da2db83ee79e7e/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jul 7, 2025

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/92b0719b56ef7f6/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jul 7, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/92b0719b56ef7f6/output.txt

Total script time: 2.36 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jul 7, 2025

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/6da2db83ee79e7e/output.txt

Total script time: 7.58 mins

  • Unit Tests: Passed

timvandermeij
timvandermeij approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the comments addressed and passing full test suite. Thank you for improving this!

@timvandermeij timvandermeij mentioned this pull request Jul 8, 2025
Merged
@calixteman
Copy link
Contributor Author

calixteman commented Jul 8, 2025

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jul 8, 2025

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/52213dc4c4d87ee/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jul 8, 2025

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/792c476e0e40074/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jul 8, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/52213dc4c4d87ee/output.txt

Total script time: 30.84 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jul 8, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/792c476e0e40074/output.txt

Total script time: 51.32 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@calixteman calixteman merged commit 0e2b59e into mozilla:master Jul 8, 2025
9 checks passed
@calixteman calixteman deleted the dict_api branch July 8, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixteman @moz-tools-bot @timvandermeij