Improve serif fallback font name matching #20224
Conversation
james-atticus
force-pushed
the
improve-serif-fallback-font-name-matching
branch
from
fe25257 to
44acabb
Compare
james-atticus
force-pushed
the
improve-serif-fallback-font-name-matching
branch
from
44acabb to
040fec1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@james-atticus the linter isn't happy: you can run it locally with |
james-atticus
force-pushed
the
improve-serif-fallback-font-name-matching
branch
from
040fec1 to
fe30d08
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/936b4c79caca1b1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9f860d71cc358d0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/936b4c79caca1b1/output.txt Total script time: 37.22 mins
Image differences available at: http://54.241.84.105:8877/936b4c79caca1b1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9f860d71cc358d0/output.txt Total script time: 75.52 mins
Image differences available at: http://54.193.163.58:8877/9f860d71cc358d0/reftest-analyzer.html#web=eq.log |
james-atticus
force-pushed
the
improve-serif-fallback-font-name-matching
branch
from
fe30d08 to
ae8f8e4
Compare
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f53846c4ac2c411/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3580a0f17575509/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f53846c4ac2c411/output.txt Total script time: 4.05 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3580a0f17575509/output.txt Total script time: 4.80 mins
|
4 participants
Extends on #14064, which was added to fix #13845.
While the initial implementation worked for some font names,
getSerifFontsuses the mapped names, egTimes. If you have a font name such asAAAAAC+TimesNewRomanPSMT(as used in the added test) orTimesNewRomanPS-BoldMT(observed in other files), then the fallback serif logic wouldn't work. This PR changes the logic to be more similar tofallbackToSystemFontwhich maps the passed-in font name throughgetStdFontMap/getNonStdFontMap.Before:
After: