Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert CodeMirror #2890

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Revert CodeMirror #2890

merged 3 commits into from
Jun 22, 2023

Conversation

mathjazz
Copy link
Collaborator

@mathjazz mathjazz commented Jun 22, 2023 •
edited
Loading

This patch reverts the CodeMirror editor and the 2 followup patches.

We need to fix #2885 and ideally also #2880 before enabling CodeMirror again.

@mathjazz mathjazz requested a review from flodolo June 22, 2023 08:13
@mathjazz
Copy link
Collaborator Author

Deployed to stage.

flodolo
flodolo approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@flodolo flodolo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duck-rubber-duck

@mathjazz mathjazz merged commit 6e1357d into mozilla:master Jun 22, 2023
@mathjazz mathjazz deleted the revert-codemirror-editor branch June 22, 2023 08:43
@eemeli eemeli mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flodolo flodolo flodolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translators can't approve pending suggestions
2 participants
@mathjazz @flodolo