From 5487f66cc983ccbf9fade7d584ec80a513bfb059 Mon Sep 17 00:00:00 2001 From: Jonathan Dygert Date: Thu, 4 Jan 2024 15:43:16 -0500 Subject: [PATCH 1/4] Expand cfg for operator storage impl --- src/cache/cache.rs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/cache/cache.rs b/src/cache/cache.rs index c31761223..925754e94 100644 --- a/src/cache/cache.rs +++ b/src/cache/cache.rs @@ -442,7 +442,15 @@ impl PreprocessorCacheModeConfig { } /// Implement storage for operator. -#[cfg(any(feature = "s3", feature = "azure", feature = "gcs", feature = "redis"))] +#[cfg(any( + feature = "azure", + feature = "gcs", + feature = "gha", + feature = "memcached", + feature = "redis", + feature = "s3", + feature = "webdav", +))] #[async_trait] impl Storage for opendal::Operator { async fn get(&self, key: &str) -> Result { From df6ef40b941a9a29dabc9be8290254c408224826 Mon Sep 17 00:00:00 2001 From: Jonathan Dygert Date: Thu, 4 Jan 2024 16:20:20 -0500 Subject: [PATCH 2/4] Add ci feature check --- .github/workflows/ci.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b8d283955..a096f9d68 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,6 +35,15 @@ jobs: - name: Check run: cargo ${{ matrix.cargo_cmd }} + check_features: + runs-on: ubuntu-latest + strategy: + matrix: + feature: [azure, gcs, gha, memcached, redis, s3, webdav] + steps: + - name: Check feature ${{ matrix.feature }} + run: cargo check --no-default-features --feature ${{ matrix.feature }} + toml_format: runs-on: ubuntu-latest steps: From 384fbe02e3b8ac3fa12dc681fbb129e7e9b7de1b Mon Sep 17 00:00:00 2001 From: Jonathan Dygert Date: Fri, 5 Jan 2024 10:00:06 -0500 Subject: [PATCH 3/4] Fix typo --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a096f9d68..46dfd5b27 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -42,7 +42,7 @@ jobs: feature: [azure, gcs, gha, memcached, redis, s3, webdav] steps: - name: Check feature ${{ matrix.feature }} - run: cargo check --no-default-features --feature ${{ matrix.feature }} + run: cargo check --no-default-features --features ${{ matrix.feature }} toml_format: runs-on: ubuntu-latest From 16ce2bad407c5c29c26e4ad30aff169405f8fbb5 Mon Sep 17 00:00:00 2001 From: Jonathan Dygert Date: Fri, 5 Jan 2024 17:34:17 -0500 Subject: [PATCH 4/4] Clone repo in ci --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 46dfd5b27..4849ae3cd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,6 +41,9 @@ jobs: matrix: feature: [azure, gcs, gha, memcached, redis, s3, webdav] steps: + - name: Clone repository + uses: actions/checkout@v4 + - name: Check feature ${{ matrix.feature }} run: cargo check --no-default-features --features ${{ matrix.feature }}