Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Worker Static Routing API (positive) #894

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Service Worker Static Routing API (positive) #894

merged 1 commit into from
Sep 29, 2023
+13 −0

Conversation

asutherland
Copy link
Member

Closes #828

asutherland
asutherland commented Sep 28, 2023
View reviewed changes
activities.json Outdated Show resolved Hide resolved
tantek
tantek requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with marking this as 'org' W3C only if the 'url' field points to a W3C WG spec or an issue on said spec.

If we want to keep the 'url' field as linking to a WICG issue, then the 'org' should be "Proposal".

@asutherland asutherland force-pushed the service-worker-static-routing-api branch from ab67a9d to 666666f Compare September 29, 2023 00:10
@asutherland
Copy link
Member Author

I'm ok with marking this as 'org' W3C only if the 'url' field points to a W3C WG spec or an issue on said spec.

If we want to keep the 'url' field as linking to a WICG issue, then the 'org' should be "Proposal".

I think the locus of activity is current on the WICG repo which has its own issues, so it probably makes sense to keep the URL as the WICG repo and mark this as Proposal, which I've now done.

@martinthomson martinthomson merged commit 9464260 into mozilla:main Sep 29, 2023
1 check passed
@sisidovski sisidovski mentioned this pull request Feb 16, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tantek tantek tantek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ServiceWorker static routing API
3 participants
@asutherland @tantek @martinthomson