From 33e948dfbba8c9a29e2dbc61236dd43bea8b0b29 Mon Sep 17 00:00:00 2001 From: Joel Purra Date: Thu, 11 Mar 2021 12:27:42 +0100 Subject: [PATCH] fix: target npm versions shipping with nodejs v12+ By default, `npm` ships with `node`. When targeting Node.js v12+, the targeted NPM versions should also be upgraded. - Node.js v12.0.0 (minimum supported by `web-ext`) ships with NPM v6.9.0. - Node.js v14.16.0 (current LTS) ships with NPM v6.14.11. - Node.js v15.11.0 (current version) ships with NPM v7.6.0. - https://nodejs.org/en/download/releases/ Changes - Updates versions mentioned in `README.md`. - The NPM version in `engines` in `package.json` has had the lower range limit updated to match the NPM version shipped with Node.js v12. - The NPM version upper range limit is due to #2146 and must be kept for now. Note that this yields `EBADENGINE` warnings when using NPM v7.0.0+, which can be ignored. --- README.md | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 93501ddc8e..d29afa8b56 100644 --- a/README.md +++ b/README.md @@ -74,8 +74,8 @@ version on the command line with this: ## Installation from source You'll need: -* [Node.js](https://nodejs.org/en/), 10.0.0 or higher -* [npm](https://www.npmjs.com/), 5.6.0 or higher is recommended +* [Node.js](https://nodejs.org/en/), 12.0.0 or higher +* [npm](https://www.npmjs.com/), 6.9.0 or higher is recommended Optionally, you may like: * [nvm](https://github.com/creationix/nvm), which helps manage node versions diff --git a/package.json b/package.json index 065ca8ff77..896f9ac096 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ ], "engines": { "node": ">=12.0.0", - "npm": ">=5.6.0 <7.0.0" + "npm": ">=6.9.0 <7.0.0" }, "engine-strict": true, "bin": {