Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Infinite recursion when custom config is used #9

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

einsteinx2
Copy link
Contributor

Summary

  • Due to a logic error, any time a customer would supply a customer Iterable config and a URL was handled, it would get into an infinite recursion loop and blow up the stack. The logic has been corrected and now works as expected (we forward to the customer's url delegate instead of to ourselves).

Testing Plan

  • Tested end to end with the TSE to ensure the behavior is now correct when using a custom config and real Iterable push notifications. We first reproduced it using the old version by passing a custom config, then updated to this branch and saw that it is now handled correctly.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit 8232001 into development Jan 10, 2023
@einsteinx2 einsteinx2 deleted the fix/SQDSDKS-4987-fix-crash branch January 10, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants