Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for macOS build #361

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Fixes for macOS build #361

merged 1 commit into from
Jan 27, 2024

Conversation

e40
Copy link
Contributor

@e40 e40 commented Jan 24, 2024

Thanks @damienstuart for help with this. It builds and works on macOS 14.3 with up-to-date Homebrew and Xcode.

@damienstuart
Copy link
Collaborator

Hi. I recommend you keep the AC_PREREQ value at 2.62. Most other distributions (including the latest Fedora and Ubuntu) have autoconf 2.71 or lower. We want to avoid forcing a newer version of Autoconf that is not available via the normal distributions.

Since AC_PREREQ specifies the minimum required version, please resubmit the pull request with it set at its current value.

Thanks,

-Damien

@e40
Copy link
Contributor Author

e40 commented Jan 27, 2024

Hi. I recommend you keep the AC_PREREQ value at 2.62. Most other distributions (including the latest Fedora and Ubuntu) have autoconf 2.71 or lower. We want to avoid forcing a newer version of Autoconf that is not available via the normal distributions.

Since AC_PREREQ specifies the minimum required version, please resubmit the pull request with it set at its current value.

Thanks,

-Damien

Done. Let me know if there's anything else you'd like changed.

Thanks for the help.

@e40
Copy link
Contributor Author

e40 commented Jan 27, 2024

@damienstuart should I change the version number or is that only done after a release?

@damienstuart
Copy link
Collaborator

damienstuart commented Jan 27, 2024 via email

@damienstuart damienstuart merged commit e11850b into mrash:master Jan 27, 2024
@mrash
Copy link
Owner

mrash commented Jan 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants