Flow events (+ support destructible types like refcounting in tasks) #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames:
bringing Weave more closely to asyncdispatch/Chronos, Cuda and OpenCL async event concept.
Actually pledges were the same concept which I didn't knew at the time.
Closes #135
Additionally, destructible types like those using refcounting were not properly supported in Tasks.
This was due to the Task data buffer not being zero initialized.
So if a destructor relied on a zero initialized type to do
if field.isNil: returnit could lead to corruption in tasks.Now tasks are zero-initialized before use. The tradeoff is 17% overhead on fibonacci (but completely invisible on matrix multiplication).
Before:
After: