Mrc 6043 tidy metadata page #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, I saw: 'Warning: React version not specified in eslint-plugin-react settings. See https://github.com/jsx-eslint/eslint-plugin-react\#configuration'
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 131 131
Lines 1225 1227 +2
Branches 339 341 +2
=======================================
+ Hits 1191 1193 +2
Misses 33 33
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
absternator
approved these changes
Nov 20, 2024
| <h3 className="text-lg font-bold tracking-tight">Timings</h3> | ||
| </span> | ||
| } | ||
| <ul className="ps-1 flex gap-10 !mt-3"> |
There was a problem hiding this comment.
whats the ! for? is it needed?
There was a problem hiding this comment.
Workaround pushed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I capitalized some lower case placeholder text on the home page, configured eslint so that it would run on my machine, and, primarily, introduced some organisation onto the metadata page.
https://mrc-ide.myjetbrains.com/youtrack/issue/mrc-6043/Make-git-execution-time-metadata-presentation-more-structured
Before
After