Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #14677, getWorldPosition and getWorldDirection have the same logic (except for the normalization of the direction) :
updateMatrixWorld( true )
Vector3
from thematrixWorld
As a follow-up to #14677 (comment), this PR introduces
setFromMatrixDirection
as the counterpart ofVector3.setFromMatrixPosition
, to be used directly when the matrixWorld is known to be up to date.For instance, it would be useful in #14658 where
light.matrixWorld
is already synced :three.js/src/renderers/webgl/WebGLLights.js
Line 205 in ddbdbaa
Note:
setFromMatrixDirection
is equivalent tosetFromMatrixColumn( m, 2 ).normalize()
but I propose it anyway as it saves a few function calls and multiplications and is more explicit.