Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpotLight: rectangular spot light shape #17528

Closed
wants to merge 6 commits into from

Conversation

nipmarsh
Copy link

This PR add the possibility to change the spot light shape from Circle to Rectangular

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 18, 2019

Um, I don't think it's a good idea to support different shapes in a hard coded way. #13057 seems to be more promising. Also note #14621.

@nipmarsh
Copy link
Author

Um, I don't think it's a good idea to support different shapes in a hard coded way. #13057 seems to be more promising.

I saw it but it is completly inactive for a while now... Maybe i can create a new type of light call RectangularSpotLight?

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 18, 2019

What if someone wants a TriangularSpotLight^^? It seems this approach does not scale very well...

@nipmarsh
Copy link
Author

nipmarsh commented Sep 18, 2019

What if then someone wants a TriangularSpotLight^^? It seems this approach does not scale very well...

I've just implemented what was suggested by @mrdoob in this comment #13057 (comment)

Regarding this comment, this PR seems to be a good idea.

Also a filter map could be added for creating any shape ;-)

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 18, 2019

I think your approach is too limited. Using a texture in the sense of Cookies is much more flexibel, IMO.

@WestLangley
Copy link
Collaborator

I think that cookies are the best way to model the "barn doors" on studio lights. I would prefer to go the cookie route.

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 7, 2019

@nipmarsh Thanks for your work on this but it's better to focus on #14621 instead.

@Mugen87 Mugen87 closed this Oct 7, 2019
@nipmarsh nipmarsh deleted the rectangular_spot_light branch May 6, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants