From 3b1ff01aa45c1a64791fb6cd094f91b8fd1fff3e Mon Sep 17 00:00:00 2001 From: Don McCurdy Date: Wed, 22 Apr 2020 22:57:14 -0700 Subject: [PATCH 1/2] bug-gltfloader-ortho-camera --- examples/js/loaders/GLTFLoader.js | 2 +- examples/jsm/loaders/GLTFLoader.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/js/loaders/GLTFLoader.js b/examples/js/loaders/GLTFLoader.js index 2bb6ef82c7d3b4..a2112e4d505e8b 100644 --- a/examples/js/loaders/GLTFLoader.js +++ b/examples/js/loaders/GLTFLoader.js @@ -2744,7 +2744,7 @@ THREE.GLTFLoader = ( function () { } else if ( cameraDef.type === 'orthographic' ) { - camera = new THREE.OrthographicCamera( params.xmag / - 2, params.xmag / 2, params.ymag / 2, params.ymag / - 2, params.znear, params.zfar ); + camera = new THREE.OrthographicCamera( - 1 * params.xmag, params.xmag, params.ymag, - 1 * params.ymag, params.znear, params.zfar ); } diff --git a/examples/jsm/loaders/GLTFLoader.js b/examples/jsm/loaders/GLTFLoader.js index 73d0a7bcd56f73..239546e1cb1b9d 100644 --- a/examples/jsm/loaders/GLTFLoader.js +++ b/examples/jsm/loaders/GLTFLoader.js @@ -2808,7 +2808,7 @@ var GLTFLoader = ( function () { } else if ( cameraDef.type === 'orthographic' ) { - camera = new OrthographicCamera( params.xmag / - 2, params.xmag / 2, params.ymag / 2, params.ymag / - 2, params.znear, params.zfar ); + camera = new OrthographicCamera( - 1 * params.xmag, params.xmag, params.ymag, - 1 * params.ymag, params.znear, params.zfar ); } From 9956e68b8840b28ef03bc0d88acc7a4d5969a630 Mon Sep 17 00:00:00 2001 From: Don McCurdy Date: Sat, 25 Apr 2020 15:52:31 -0700 Subject: [PATCH 2/2] GLTFLoader: Clean up. --- examples/js/loaders/GLTFLoader.js | 2 +- examples/jsm/loaders/GLTFLoader.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/js/loaders/GLTFLoader.js b/examples/js/loaders/GLTFLoader.js index a2112e4d505e8b..667d76a6aaa803 100644 --- a/examples/js/loaders/GLTFLoader.js +++ b/examples/js/loaders/GLTFLoader.js @@ -2744,7 +2744,7 @@ THREE.GLTFLoader = ( function () { } else if ( cameraDef.type === 'orthographic' ) { - camera = new THREE.OrthographicCamera( - 1 * params.xmag, params.xmag, params.ymag, - 1 * params.ymag, params.znear, params.zfar ); + camera = new THREE.OrthographicCamera( - params.xmag, params.xmag, params.ymag, - params.ymag, params.znear, params.zfar ); } diff --git a/examples/jsm/loaders/GLTFLoader.js b/examples/jsm/loaders/GLTFLoader.js index 239546e1cb1b9d..5bfe5fe248df3e 100644 --- a/examples/jsm/loaders/GLTFLoader.js +++ b/examples/jsm/loaders/GLTFLoader.js @@ -2808,7 +2808,7 @@ var GLTFLoader = ( function () { } else if ( cameraDef.type === 'orthographic' ) { - camera = new OrthographicCamera( - 1 * params.xmag, params.xmag, params.ymag, - 1 * params.ymag, params.znear, params.zfar ); + camera = new OrthographicCamera( - params.xmag, params.xmag, params.ymag, - params.ymag, params.znear, params.zfar ); }