From cc8dd11580fe3d2fdcb7367808a0fe176273052b Mon Sep 17 00:00:00 2001 From: Mugen87 Date: Fri, 18 Oct 2024 23:39:18 +0200 Subject: [PATCH 1/3] GLTFExporter: Better defaults for metallic and roughness factors. --- examples/jsm/exporters/GLTFExporter.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/jsm/exporters/GLTFExporter.js b/examples/jsm/exporters/GLTFExporter.js index f421c1c4aa6413..4661958d176c38 100644 --- a/examples/jsm/exporters/GLTFExporter.js +++ b/examples/jsm/exporters/GLTFExporter.js @@ -1524,8 +1524,8 @@ class GLTFWriter { } else { - materialDef.pbrMetallicRoughness.metallicFactor = 0.5; - materialDef.pbrMetallicRoughness.roughnessFactor = 0.5; + materialDef.pbrMetallicRoughness.metallicFactor = 0; + materialDef.pbrMetallicRoughness.roughnessFactor = 1; } From 6b10d6fb7d2beb4c510e9635510cb348c100afc1 Mon Sep 17 00:00:00 2001 From: Mugen87 Date: Sat, 19 Oct 2024 10:38:14 +0200 Subject: [PATCH 2/3] GLTFExporter: Stick to glTF spec. --- examples/jsm/exporters/GLTFExporter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/jsm/exporters/GLTFExporter.js b/examples/jsm/exporters/GLTFExporter.js index 4661958d176c38..dea0c6e1d4dceb 100644 --- a/examples/jsm/exporters/GLTFExporter.js +++ b/examples/jsm/exporters/GLTFExporter.js @@ -1524,7 +1524,7 @@ class GLTFWriter { } else { - materialDef.pbrMetallicRoughness.metallicFactor = 0; + materialDef.pbrMetallicRoughness.metallicFactor = 1; materialDef.pbrMetallicRoughness.roughnessFactor = 1; } From 8832969439b67c7ad44cb6f35c7895dffb708220 Mon Sep 17 00:00:00 2001 From: Mugen87 Date: Sat, 19 Oct 2024 14:39:55 +0200 Subject: [PATCH 3/3] GLTFExporter: Clean up. --- examples/jsm/exporters/GLTFExporter.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/jsm/exporters/GLTFExporter.js b/examples/jsm/exporters/GLTFExporter.js index dea0c6e1d4dceb..89bb2cd3cf5bf9 100644 --- a/examples/jsm/exporters/GLTFExporter.js +++ b/examples/jsm/exporters/GLTFExporter.js @@ -1524,8 +1524,7 @@ class GLTFWriter { } else { - materialDef.pbrMetallicRoughness.metallicFactor = 1; - materialDef.pbrMetallicRoughness.roughnessFactor = 1; + materialDef.pbrMetallicRoughness.metallicFactor = 0; // default roughness is 1 }