Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes github actions dist cache key #61

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fixes github actions dist cache key #61

merged 1 commit into from
Jul 12, 2024

Conversation

mhassan1
Copy link
Collaborator

This PR puts back env.commit-sha in Github Actions, which seems to have been inadvertently changed (in https://github.com/mrhenry/polyfill-library/pull/39/files#diff-765809e3c0b1f9439625007384022dd3e6d70070bed6898f3a00fa3371d6c89fR60) to env.GITHUB_SHA, which doesn't exist.

Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@romainmenke romainmenke merged commit fb6f7da into main Jul 12, 2024
17 checks passed
@romainmenke romainmenke deleted the fix-dist-cache branch July 12, 2024 06:52
mhassan1 added a commit that referenced this pull request Jul 12, 2024
This PR puts back `env.commit-sha` in Github Actions, which seems to
have been inadvertently changed (in
https://github.com/mrhenry/polyfill-library/pull/39/files#diff-765809e3c0b1f9439625007384022dd3e6d70070bed6898f3a00fa3371d6c89fR60)
to `env.GITHUB_SHA`, which doesn't exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants