Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to set config_file via environment variable #195

Merged
merged 6 commits into from
Sep 10, 2023
Merged

Allow user to set config_file via environment variable #195

merged 6 commits into from
Sep 10, 2023

Conversation

botan
Copy link
Contributor

@botan botan commented Aug 31, 2023

Closes #194

@mrkaye97 mrkaye97 self-assigned this Aug 31, 2023
@mrkaye97 mrkaye97 self-requested a review August 31, 2023 21:34
mrkaye97
mrkaye97 reviewed Aug 31, 2023
View reviewed changes
Copy link
Owner

@mrkaye97 mrkaye97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this in! Looks like I might need to wrestle with CI a little bit -- I'll report back

R/slackr_setup.r Outdated Show resolved Hide resolved
README.Rmd Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@botan
Copy link
Contributor Author

botan commented Aug 31, 2023

No problem, please let me know if anything else I might need to change.

@mrkaye97 mrkaye97 changed the base branch from master to dev September 10, 2023 16:54
@mrkaye97
Copy link
Owner

merging into dev. thanks for the contribution! I'll keep wrestling with CI to get this over the line

@mrkaye97 mrkaye97 merged commit 31ac3ff into mrkaye97:dev Sep 10, 2023
1 of 6 checks passed
@botan
Copy link
Contributor Author

botan commented Sep 10, 2023

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkaye97 mrkaye97 mrkaye97 left review comments

Assignees

@mrkaye97 mrkaye97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow user to set config_file via environment variable
2 participants
@botan @mrkaye97