Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Find all references" feature doesn't work #35

Open
dko-slapdash opened this issue Aug 15, 2019 · 3 comments
Open

"Find all references" feature doesn't work #35

dko-slapdash opened this issue Aug 15, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dko-slapdash
Copy link

Thanks again for the plugin!

Looks like the feature "find all references to a particular css class" doesn't work in vscode.

Here is an animated GIF illustration:

Aug-14-2019 23-32-16

What's interesting is that if I run "Find all references" from the side of a tsx file, it ALMOST works. Here is a GIF showing how it "almost works" from that side:

Aug-14-2019 23-36-07

Looks like if it's run from the tsx side, the plugin messes up offset of css classes in the css file. (Could also be that it's the consequence of #34 bug.)

@mrmckeb
Copy link
Owner

mrmckeb commented Aug 16, 2019

I think this would be solved by #34 as you've pointed out... let me look into potential solutions for this.

@mrmckeb mrmckeb added enhancement New feature or request help wanted Extra attention is needed labels Sep 7, 2019
@mrmckeb
Copy link
Owner

mrmckeb commented Sep 7, 2019

So, I've looked into this a little more and I think that the second issue may be fixed by #34, but the first issue won't be.

This would require a VSCode extension I believe, as this plugin (and TypeScript) aren't operational when the CSS file is open.

I've marked this as an enhancement, but I think this will only be partially fixable... Of course, that doesn't mean we shouldn't try :)

@mrmckeb mrmckeb added this to the v1.4.0 milestone Sep 15, 2019
@mrmckeb mrmckeb modified the milestones: v2.0.0, v2.1.0 Oct 20, 2019
@mrmckeb mrmckeb modified the milestones: v2.1.0, v2.2.0 Dec 1, 2019
@mrmckeb
Copy link
Owner

mrmckeb commented Dec 4, 2022

This isn't working correctly as even with #34 solved, apologies. I'm not sure this is doable, as go to definition works now - yet the reference is still on the wrong line.

@mrmckeb mrmckeb removed this from the v2.2.0 milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants