docs: Fix Promise type in C++

mrousavy · Jan 13, 2025 · bf28dc4 · bf28dc4
1 parent f2a9e08
commit bf28dc4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/docs/docs/errors.md b/docs/docs/errors.md
@@ -90,7 +90,7 @@ Promises can also be rejected using error throwing syntax on the native side:
   <TabItem value="cpp" label="C++">
     ```cpp title="HybridMath.hpp"
     class HybridMath: public HybridMathSpec {
-      Promise<double> add(double a, double b) override {
+      std::shared_ptr<Promise<double>> add(double a, double b) override {
         return Promise<double>::async([=]() -> double {
           if (a < 0 || b < 0) {
             throw std::runtime_error("Value cannot be negative!");

diff --git a/docs/docs/sync-vs-async.md b/docs/docs/sync-vs-async.md
@@ -84,7 +84,7 @@ On the native side you still start out with a synchronous method, but you can re
   <TabItem value="cpp" label="C++">
     ```cpp title="HybridMiner.hpp"
     class HybridMiner: public HybridMinerSpec {
-      Promise<double> mineOneBitcoin() override {
+      std::shared_ptr<Promise<double>> mineOneBitcoin() override {
         // 1. synchronous in here, JS Thread is still blocked
         //    useful e.g. for argument checking before starting async Thread
         return Promise<double>::async([]() {